----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64750/#review194254 -----------------------------------------------------------
Ship it! Let's add some unit test to capture this regression! - Jie Yu On Dec. 20, 2017, 2:22 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64750/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 2:22 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Initially it was valid to assert that 'checkpointResources' would > never be called for an agent with resource providers, but we have > sinced moved to an implementation where we might perform checkpointing > of agent resources (but never local resource provider resources). > > This patch adjusts an assertion in the agent's 'checkpointResources' > function to that reality. > > > Diffs > ----- > > src/slave/slave.cpp 264705f9e8fc91407aae691dc9f6d4dc5048dfaa > > > Diff: https://reviews.apache.org/r/64750/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
