----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64754/ -----------------------------------------------------------
(Updated Dec. 21, 2017, 3:41 a.m.) Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod Kone. Changes ------- Addressed Ben's comment: killing the helpers. Summary (updated) ----------------- Removed `kilobytes()`, `megabytes()`, etc from `Bytes`. Repository: mesos Description (updated) ------- These functios are removed because they are lossy. The unit conversion for `Resource` should be explicit. For example: `resource.scalar().set_value(size.bytes() * 1.0 / Bytes::MEGABYTES)` Diffs (updated) ----- 3rdparty/stout/include/stout/bytes.hpp cbe953662bb86c2f1eef3453f557ea17c0c6d13e Diff: https://reviews.apache.org/r/64754/diff/2/ Changes: https://reviews.apache.org/r/64754/diff/1-2/ Testing ------- See later in chain. Thanks, Chun-Hung Hsiao
