----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/#review194339 -----------------------------------------------------------
src/executor/v0_v1executor.cpp Lines 192 (patched) <https://reviews.apache.org/r/64070/#comment273101> Can you please move this check to the beginning of the method for better code consistency here and in `shutdown`, `killTask` methods? - Andrei Budnik On Dec. 20, 2017, 8:16 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64070/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 8:16 p.m.) > > > Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Prior to this patch, if an error, kill, or shutdown occurred during > subscription / registration with the agent, it was not propagated back > to the executor if the v0_v1 executor adapter was used. This happened > because the adapter did not call the `connected` callback until after > successful registration and hence the executor did not even try to > send the `SUBSCRIBE` call, without which the adapter did not send any > events to the executor. > > A fix is to call the `connected` callback if an error occurred or > shutdown / kill event arrived before the executor had subscribed. > > > Diffs > ----- > > src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb > > > Diff: https://reviews.apache.org/r/64070/diff/2/ > > > Testing > ------- > > > Thanks, > > Alexander Rukletsov > >
