----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194361 -----------------------------------------------------------
Fix it, then Ship it! Thanks for the updated patch Alex, for me this version is much clearer. src/linux/ns.cpp Line 397 (original), 397-399 (patched) <https://reviews.apache.org/r/64686/#comment273124> Why do we put `struct` here? This is C++ (and the `memcpy` fits on a single line w/o it). Not yours, but we should probably also include `sys/socket.h` for `ucred` in this file. src/linux/ns.cpp Line 455 (original), 459 (patched) <https://reviews.apache.org/r/64686/#comment273125> `struct`? src/linux/ns.cpp Lines 472 (patched) <https://reviews.apache.org/r/64686/#comment273126> `struct`? - Benjamin Bannier On Dec. 21, 2017, 8:42 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64686/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 8:42 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park. > > > Bugs: MESOS-6616 > https://issues.apache.org/jira/browse/MESOS-6616 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139 > > > Diff: https://reviews.apache.org/r/64686/diff/2/ > > > Testing > ------- > > make check on Mac OS 10.11.6 and various Linux distros > > > Thanks, > > Alexander Rukletsov > >
