----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194516 -----------------------------------------------------------
src/slave/http.cpp Lines 2452 (patched) <https://reviews.apache.org/r/56722/#comment273307> In your scenario, if the operator wants to persist the excluded_images selection while auto gc is enabled, requiring it to be configured in the agent flag seems reasonable to me. I think this API is useful for opertors who cannot use auto gc for whatever reason (i.e, disk space calculation is not applicable), so I don't see it is a real problem. Keeping this field out seems a strange discrepancy between the operator API and agent flag. - Zhitao Li On Dec. 24, 2017, 7:31 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56722/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2017, 7:31 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-4945 > https://issues.apache.org/jira/browse/MESOS-4945 > > > Repository: mesos > > > Description > ------- > > Added a new operator API for `PRUNE_IMAGES`. > > > Diffs > ----- > > include/mesos/agent/agent.proto 25af6dc64ca35126fd70dd10388bd2cea6dcbd36 > include/mesos/v1/agent/agent.proto 4ae9013e6fb27bdce72b4aa9fc9cbd99f79bc548 > src/slave/http.hpp 3cdbf988db923801e2b3d93cf60b33ad14653742 > src/slave/http.cpp 3e20c90fb94f0128a757745052534ef03612d849 > src/slave/validation.cpp b7243fc2316a69efa23285bf3394104e0d58759e > > > Diff: https://reviews.apache.org/r/56722/diff/9/ > > > Testing > ------- > > 1. New unit test to trigger the new call. > 2. Manually tested that images previous pulled but not running can be purged > through new operator API call while active images (running or being pulled) > are not affected. > > > Thanks, > > Zhitao Li > >