> On Dec. 21, 2017, 6:55 p.m., Benjamin Mahler wrote: > > Hm.. I was a little puzzled here, why do some use convert with POST and > > some use the reflection based upgrade? Shouldn't we just use the reflection > > based upgrade everywhere?
Sorry for the confusion. The `upgradeResources` used here is the one pulled out of `validateAndUpgradeResources`, and is not "reflection based upgrade". I called it `upgradeResources` for now in the hopes that when we do introduce reflection-based `upgradeResources`, the callsite wouldn't need to change. Although looking at it now we'll probably be invoking the reflection-based upgrade on all of `resourceProviderState` i.e., `upgradeResources(resourceProviderState.get());` - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64739/#review194396 ----------------------------------------------------------- On Dec. 19, 2017, 4:51 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64739/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2017, 4:51 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 79d7f602bbc57bce308157dfbb6c2afaef806f23 > src/slave/containerizer/mesos/paths.cpp > 8a188a918873eef468a984b80f5ea7ebaa8fb923 > > > Diff: https://reviews.apache.org/r/64739/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
