----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review194604 -----------------------------------------------------------
src/python/lib/mesos/http.py Lines 149 (patched) <https://reviews.apache.org/r/61172/#comment273467> actually this has to be None if we want to allow defaults and overrides. a None passed in indicates that we're not overriding -- if the default value is boolean, there is no way to tell whether this was passed in by the user or whether it was just the default value. - Eric Chung On Jan. 1, 2018, 1:52 a.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61172/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2018, 1:52 a.m.) > > > Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Part of MESOS-7310, this patch adds the mesos.http and mesos.exceptions > modules, which provides a Resource class and its descendants for > abstracting away common operations over http connectioins with JSON > serialization. > > updated patch according to klueska's recommendations > > > addressed comments > > > Diffs > ----- > > src/python/cli_new/bootstrap c84e549e59bc7a07b5b70c24c63bc0c16881e442 > src/python/lib/mesos/exceptions.py PRE-CREATION > src/python/lib/mesos/http.py PRE-CREATION > src/python/lib/requirements.in e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > src/python/lib/tests/conftest.py PRE-CREATION > src/python/lib/tests/test_exceptions.py PRE-CREATION > src/python/lib/tests/test_http.py PRE-CREATION > src/python/lib/tox.ini 8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054 > support/pylint.config f74f553e238553bd6a6c06f4dd888cc5954a33eb > > > Diff: https://reviews.apache.org/r/61172/diff/8/ > > > Testing > ------- > > install tox > cd src/python/lib > tox > > > Thanks, > > Eric Chung > >
