> On Jan. 8, 2018, 2:54 p.m., Gaston Kleiman wrote: > >
I can't review the powershell commands, but the rest looks sane. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/#review194992 ----------------------------------------------------------- On Jan. 4, 2018, 4:31 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64386/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 4:31 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, Jie Yu, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > The network health checks called curl and then executed setns to > enter to container network namespace, which did not work on Windows. > To do the equivalent, Windows nows calls docker run with powershell's > curl equivalent (Invoke-WebRequest) and uses the > network=container:<ID> flag to enter the container's namespace. > > > Diffs > ----- > > src/checks/checker.hpp 93502270f31e80c5f7c94b5b456625e9cdea1837 > src/checks/checker.cpp fff0aac504b4283a210f936e00c977fa60d88b3d > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > src/checks/health_checker.hpp 019fbd791f250ecc28ff59d779f90e7ccbf0c685 > src/checks/health_checker.cpp eaf9a18817eeeff7c29c7a4b9d1b183f398760a3 > src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 > src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a > src/launcher/executor.cpp 794bf7ca07e68c7d83993546c134f85cac5a68e3 > > > Diff: https://reviews.apache.org/r/64386/diff/4/ > > > Testing > ------- > > See https://reviews.apache.org/r/64387/ > > > Thanks, > > Akash Gupta > >
