----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64847/#review195007 -----------------------------------------------------------
src/examples/example_framework_flags.hpp Lines 17 (patched) <https://reviews.apache.org/r/64847/#comment274105> I would just name the file `flags.cpp` to be consistent with how we did master and agent flags? You would also need to change the MACRO here correspondingly. src/examples/example_framework_flags.hpp Lines 32 (patched) <https://reviews.apache.org/r/64847/#comment274106> It's not clear to me why you broke down the flags like this? Also, not clear why v0 and v1 have different flags. Can you provide more context? - Vinod Kone On Dec. 28, 2017, 2:06 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64847/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2017, 2:06 a.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, > Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-8357 > https://issues.apache.org/jira/browse/MESOS-8357 > > > Repository: mesos > > > Description > ------- > > Adds a set if flags exclusively used by our example frameworks. This > enhancement aids in unifying the user experience when tinkering with > our examples. > > > Diffs > ----- > > src/examples/example_framework_flags.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64847/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
