> On Jan. 15, 2018, 3:01 a.m., Vinod Kone wrote: > > Can you expand on the description on why this change is necessary?
Done. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65156/#review195403 ----------------------------------------------------------- On Jan. 15, 2018, 9:16 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65156/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2018, 9:16 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8444 > https://issues.apache.org/jira/browse/MESOS-8444 > > > Repository: mesos > > > Description > ------- > > Previously we only detach the following paths when the gc for the > executor's sandbox succeeds. > 1. /agent_workdir/frameworks/FID/executors/EID/runs/CID > 2. /agent_workdir/frameworks/FID/executors/EID/runs/latest > 3. /frameworks/FID/executors/EID/runs/latest > > But the problem is, such gc may not always succeed, e.g., it may fail > due to the parent directory of the executor's sandbox already gc'ed. > > Now in this patch, we will detach those paths regardless of the result > of gc. > > > Diffs > ----- > > src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850 > > > Diff: https://reviews.apache.org/r/65156/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
