----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/#review195515 -----------------------------------------------------------
src/examples/dynamic_reservation_framework.cpp Line 41 (original) <https://reviews.apache.org/r/64849/#comment274706> Any particular reason you deleted these? src/examples/persistent_volume_framework.cpp Line 501 (original) <https://reviews.apache.org/r/64849/#comment274707> Why did you revert this change introduced in the previous review? src/examples/test_http_framework.cpp Line 401 (original), 390 (patched) <https://reviews.apache.org/r/64849/#comment274708> aah you fixed in this review! - Vinod Kone On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64849/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2018, 12:29 a.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, > Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-5362 and MESOS-8357 > https://issues.apache.org/jira/browse/MESOS-5362 > https://issues.apache.org/jira/browse/MESOS-8357 > > > Repository: mesos > > > Description > ------- > > All example frameworks now support authenticating when registering > to the master. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp > 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 > src/examples/persistent_volume_framework.cpp > 71db39d7743d31ea34c2aed579d7a1ef2ed95687 > src/examples/test_http_framework.cpp > 482f65efc15a7bac52c33a57b2b876191249410a > src/tests/persistent_volume_framework_test.sh > 2ab22c03e573d4801c73957f9cad2939b3d3174b > > > Diff: https://reviews.apache.org/r/64849/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >