----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review195637 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Jan. 16, 2018, 8:54 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63859/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 8:54 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > Removed `SIGSTOP` and `SIGCONT` on Windows, since they are meaningless, > and never unused. Also, fixed the WEXITSTATUS macro to cast the exit > code instead of bit-masking it, since Windows exit codes are 32 bit > unsigned ints. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/kill.hpp > b2a36b5c07df6642bb9b08b61ab3b678bf8a6b36 > 3rdparty/stout/include/stout/windows.hpp > 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 > > > Diff: https://reviews.apache.org/r/63859/diff/7/ > > > Testing > ------- > > See https://reviews.apache.org/r/63862/ for test results. > > > Thanks, > > Akash Gupta > >
