----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/#review195938 -----------------------------------------------------------
3rdparty/libprocess/Makefile.am Lines 200 (patched) <https://reviews.apache.org/r/65201/#comment275349> I don't really like adding this testing tool to `libprocess`. Could you introduce some convenience library here the mesos and libprocess tests could link to (similar for cmake). 3rdparty/libprocess/include/process/gtest.hpp Line 249 (original), 251 (patched) <https://reviews.apache.org/r/65201/#comment275350> We don't really fully qualify the names here, but instead use just `process::...` elsewhere. Let's stick to that, and potentially clean up globally if we really want it. Here and below. 3rdparty/libprocess/include/process/gtest.hpp Line 446 (original), 448 (patched) <https://reviews.apache.org/r/65201/#comment275351> Let's just wrap this macro definition so we do not need to worry about accidentally commenting out code when expanding, e.g., #define AWAIT_ASSERT_RESPONSE_HEADER_EQ_FOR(expected, key, actual, duration) \ ASSERT_PRED_FORMAT4( \ AwaitAssertResponseHeaderEq, \ expected, \ key, \ actual, \ duration) 3rdparty/libprocess/include/process/gtest.hpp Line 454 (original), 456 (patched) <https://reviews.apache.org/r/65201/#comment275352> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 489 (original), 491 (patched) <https://reviews.apache.org/r/65201/#comment275353> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 497 (original), 499 (patched) <https://reviews.apache.org/r/65201/#comment275354> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 538 (original), 540 (patched) <https://reviews.apache.org/r/65201/#comment275355> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 546 (original), 548 (patched) <https://reviews.apache.org/r/65201/#comment275356> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 620 (original), 622 (patched) <https://reviews.apache.org/r/65201/#comment275357> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 628 (original), 630 (patched) <https://reviews.apache.org/r/65201/#comment275358> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 661 (original), 663 (patched) <https://reviews.apache.org/r/65201/#comment275359> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 702 (original), 704 (patched) <https://reviews.apache.org/r/65201/#comment275360> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 751 (original), 753 (patched) <https://reviews.apache.org/r/65201/#comment275361> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 784 (original), 786 (patched) <https://reviews.apache.org/r/65201/#comment275362> Ditto. 3rdparty/libprocess/include/process/gtest.hpp Line 792 (original), 794 (patched) <https://reviews.apache.org/r/65201/#comment275363> Ditto. 3rdparty/libprocess/src/gtest.cpp Lines 1 (patched) <https://reviews.apache.org/r/65201/#comment275364> Let's also add this file to the cmake build setup. - Benjamin Bannier On Jan. 18, 2018, 12:54 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65201/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 12:54 a.m.) > > > Review request for mesos, Benjamin Bannier and Gaston Kleiman. > > > Bugs: MESOS-7016 > https://issues.apache.org/jira/browse/MESOS-7016 > > > Repository: mesos > > > Description > ------- > > Added a global `DEFAULT_TEST_TIMEOUT` variable that applications > can use to globally tune the default timeout in the `AWAIT_READY` > family of test macros. The default remains 15sec. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am ba9e78148932304ce1961b88e5f97180abd35586 > 3rdparty/libprocess/include/process/gtest.hpp > eee726653d52af2e4a148819e420ebd22e5123a9 > 3rdparty/libprocess/src/gtest.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65201/diff/2/ > > > Testing > ------- > > make check (Fedora 27). > > > Thanks, > > James Peach > >
