> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 842-843 (original), 845-852 (patched) > > <https://reviews.apache.org/r/65261/diff/1/?file=1943241#file1943241line849> > > > > If you add an override for `getContainerIOSwitchboardSocketTempPath()` > > that takes same arguments as `getContainerIOSwitchboardSocketPath()`, this > > snippet will reduce to a tertiary operator and will become more readable. > > Andrei Budnik wrote: > `getContainerIOSwitchboardSocketTempPath()` is also used in > `IOSwitchboardServer::create()`, so it looks like we can't have same > arguments as for `getContainerIOSwitchboardSocketPath`.
Why not? Just add an override. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196009 ----------------------------------------------------------- On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65261/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 1 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-7742 > https://issues.apache.org/jira/browse/MESOS-7742 > > > Repository: mesos > > > Description > ------- > > Once IOSwitchboard's unix socket appears in the file system, the agent > can try to connect to it. If the agent attempts to connect to the > socket before `listen` has been called, then it gets connection refused > error. To address this, create a unix socket using a temporary name, > then initialize it, then rename the socket with the original path. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 45b615be60af9af839309011eea85912c01ff451 > src/slave/containerizer/mesos/paths.hpp > 65830a153f765c74bb0399bca9b2941390eeb531 > src/slave/containerizer/mesos/paths.cpp > 0df4cf5f50aee94a2758ce885389fb488a85fdbd > > > Diff: https://reviews.apache.org/r/65261/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
