----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/#review196161 -----------------------------------------------------------
src/tests/api_tests.cpp Lines 2598-2600 (patched) <https://reviews.apache.org/r/65316/#comment275681> Please use this instead: ``` EXPECT_CALL(*scheduler, connected(_)) .WillOnce(v1::scheduler::SendSubscribe(v1::DEFAULT_FRAMEWORK_INFO)); ``` src/tests/api_tests.cpp Lines 2620 (patched) <https://reviews.apache.org/r/65316/#comment275682> You don't need this if you remove the `connected` future and make the expectation use `v1::scheduler::SendSubscribe`. src/tests/api_tests.cpp Lines 2742-2757 (patched) <https://reviews.apache.org/r/65316/#comment275683> You can use: ``` mesos.send( v1::createCallAccept( frameworkId, offer, {v1::LAUNCH({taskInfo})); ``` - Gaston Kleiman On Jan. 24, 2018, 11:38 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65316/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 11:38 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone. > > > Bugs: MESOS-8469 > https://issues.apache.org/jira/browse/MESOS-8469 > > > Repository: mesos > > > Description > ------- > > Until the fix for MESOS-8469, it was possible for the master > operator event stream to drop events, if event-related state in > the master changed in between asynchronous calls. > > This patch adds `MasterAPITest.EventAuthorizationDelayed` to > verify the fix for that issue. > > > Diffs > ----- > > src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 > > > Diff: https://reviews.apache.org/r/65316/diff/1/ > > > Testing > ------- > > Confirmed that the test fails without the fix for MESOS-8469. > > When the fix is included, the test passes. Successfully ran > `bin/mesos-tests.sh > --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" > --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness. > > > Thanks, > > Greg Mann > >
