----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/#review196262 -----------------------------------------------------------
PASS: Mesos patch 65322 was successfully built and tested. Reviews applied: `['65322']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65322 - Mesos Reviewbot Windows On Jan. 25, 2018, 2:32 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65322/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2018, 2:32 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Cong Wang. > > > Bugs: MESOS-8484 > https://issues.apache.org/jira/browse/MESOS-8484 > > > Repository: mesos > > > Description > ------- > > Previously we relied on Boost to never successfully parse hexadecimal > numbers, and only performed rejection of hexadecimal floating point > numbers before entering our custom parser for hexadecimal numbers. > This was not reliable as on some platforms `boost::lexical_cast` ended > up successfully parsing literals of hexadecimal floating point numbers > leading us to never rejecting hexadecimal floating point numbers. > > This patch moves the rejection of hexadecimal floating point numbers > to a point before attempting a parse with `boost::lexical_cast`. While > this decouples us in some regards from Boost's parsing behavior, we > also might end up performing more work than needed. Should this become > a concern we should revisit and optimize the implementation here. > > > Diffs > ----- > > 3rdparty/stout/include/stout/numify.hpp > 6db9a78145b7e90cc975786ca83f7acb7fdc3e0a > > > Diff: https://reviews.apache.org/r/65322/diff/2/ > > > Testing > ------- > > `make check` on a collection of Linux, macos and Windows setups in internal > CI. > > > Thanks, > > Benjamin Bannier > >
