----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review196354 -----------------------------------------------------------
PASS: Mesos patch 65350 was successfully built and tested. Reviews applied: `['65350']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65350 - Mesos Reviewbot Windows On Jan. 26, 2018, 2:17 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65350/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2018, 2:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > ------- > > This patch modifies `cgroup::prepare` function to save the results of > a test for a nested cgroups support in a hashmap to reuse it in the > future. > > Besides optimization, this patch fixes flaky > `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There > was a race condition between two starting agents, where the first > agent could detect `test` orphaned container while iterating over > `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent > is calling `cgroup::prepare` during its initialization. This patch > fixes the test, because it won't create a `test` cgroup in > `cgroups::prepare` as this test has already been passed during the > initialization of the first agent and the result is stored in hashmap. > > > Diffs > ----- > > src/linux/cgroups.cpp cdd0f40ec5748b909e529f21b15523122bf90d41 > > > Diff: https://reviews.apache.org/r/65350/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >