> On Jan. 25, 2018, 9:10 p.m., Anish Gupta wrote: > > src/cli/execute.cpp > > Lines 1077-1082 (patched) > > <https://reviews.apache.org/r/65294/diff/1/?file=1944612#file1944612line1077> > > > > Why not unconditionally set it since resources are not revocable unless > > have RevocableInfo
I feel that is unnecessary, and receiving resources which this utility may not need is unnecessary behavior change. Inferring this capability from input resources seems clean enough to me. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/#review196286 ----------------------------------------------------------- On Jan. 24, 2018, 9:51 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65294/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 9:51 p.m.) > > > Review request for mesos, Anish Gupta, Jason Lai, and James Peach. > > > Bugs: MESOS-8471 > https://issues.apache.org/jira/browse/MESOS-8471 > > > Repository: mesos > > > Description > ------- > > This allows user to use `mesos-execute` to quickly test over subscription. > > > Diffs > ----- > > src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe > > > Diff: https://reviews.apache.org/r/65294/diff/1/ > > > Testing > ------- > > Submitted a test task with following configuration: > ``` > { > "name": "Name", > "task_id": {"value" : "1"}, > "agent_id": {"value" : ""}, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "revocable": {}, > "scalar": { > "value": 0.1 > } > } > ], > "command": { > "value": "sleep 1000" > } > } > ``` > > With command `mesos-execute --master=localhost:5050 --revocable_resources > --task=file:///home/user/test_rev_task.json` > > If the master/agent has revocable cpu, this allows the task to execute. > > > Thanks, > > Zhitao Li > >
