----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/#review196381 -----------------------------------------------------------
src/slave/slave.cpp Line 4652 (original), 4659 (patched) <https://reviews.apache.org/r/65109/#comment276014> Need this also in the subscribe case? - Benjamin Mahler On Jan. 26, 2018, 11:13 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65109/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2018, 11:13 p.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-8411 > https://issues.apache.org/jira/browse/MESOS-8411 > > > Repository: mesos > > > Description > ------- > > An executor should be shutdown if it has never got any tasks > i.e. all of its initial tasks are killed before launching. > See MESOS-8411. > > This patch ensures this by checking an executor's various > tasks queues during task kill and executor registration, > and shutting down executors that had never received any tasks. > > > Diffs > ----- > > src/slave/constants.hpp e6cb7cc0ccdaaf981eb66defa21b38720f4e1de9 > src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 > src/slave/slave.cpp 43c7955237655accdf869db1b6494a35f77acdb3 > > > Diff: https://reviews.apache.org/r/65109/diff/5/ > > > Testing > ------- > > make check > new tests in #65111 > > > Thanks, > > Meng Zhu > >
