----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65367/#review196385 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/type_utils.hpp Lines 234-249 (patched) <https://reviews.apache.org/r/65367/#comment276015> Should we try to start using https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.util.message_differencer? Commented on: https://issues.apache.org/jira/browse/MESOS-2487 - Benjamin Mahler On Jan. 27, 2018, 1:40 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65367/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2018, 1:40 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7882 > https://issues.apache.org/jira/browse/MESOS-7882 > > > Repository: mesos > > > Description > ------- > > This will be used to compare parts of maintenance schedules for changes. > > > Diffs > ----- > > include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 > include/mesos/v1/mesos.hpp d4c354ab596a6ea361f2fe45afa46089f8c1a543 > > > Diff: https://reviews.apache.org/r/65367/diff/1/ > > > Testing > ------- > > See next review. > > > Thanks, > > Joseph Wu > >
