----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/#review196481 -----------------------------------------------------------
Ship it! But let's double check that socket bit for Linux. Seems just fine. - Andrew Schwartzmeyer On Jan. 29, 2018, 10:20 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65393/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 10:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The original command health check was calling `docker exec` instead > of `docker -H <docker_socket> exec`, so it was ignoring the socket > value passed to the docker executor. > > > Diffs > ----- > > src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 > src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a > > > Diff: https://reviews.apache.org/r/65393/diff/1/ > > > Testing > ------- > > ran mesos-tests --docker flag. > > > Thanks, > > Akash Gupta > >