----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/#review196580 -----------------------------------------------------------
3rdparty/libprocess/include/process/grpc.hpp Lines 142 (patched) <https://reviews.apache.org/r/65426/#comment276283> Newline above or move this line above `set_deadline()`. Also, should we add comments to explain `wait_for_ready` represents the re-try in gRPC? - Gilbert Song On Jan. 30, 2018, 4:59 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65426/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 4:59 p.m.) > > > Review request for mesos, Greg Mann and Jie Yu. > > > Bugs: MESOS-8514 > https://issues.apache.org/jira/browse/MESOS-8514 > > > Repository: mesos > > > Description > ------- > > It takes long in gRPC 1.8 to prepare a domain socket, and as a result, > SLRP cannot talk to a CSI plugin immediately after the socket file is > created. This patch fixes this problem by asking gRPC calls to wait for > the socket to be ready. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/grpc.hpp > 0f63e576f04af4df8894626eebbb1a0e01eadf22 > > > Diff: https://reviews.apache.org/r/65426/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >