----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196878 -----------------------------------------------------------
Fix it, then Ship it! src/tests/flags.hpp Lines 49 (patched) <https://reviews.apache.org/r/65202/#comment276771> Let's rename this to `test_await_timeout`. src/tests/flags.cpp Lines 170 (patched) <https://reviews.apache.org/r/65202/#comment276772> `test_await_timeout`. src/tests/main.cpp Lines 21 (patched) <https://reviews.apache.org/r/65202/#comment276773> If we move the test await timeout to a file of constants we would include its header file here. Here and below. - Benjamin Bannier On Feb. 5, 2018, 11:50 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65202/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 11:50 p.m.) > > > Review request for mesos, Benjamin Bannier and Gaston Kleiman. > > > Bugs: MESOS-7016 > https://issues.apache.org/jira/browse/MESOS-7016 > > > Repository: mesos > > > Description > ------- > > Rather than hard-coding a 15sec test timeout, use the libprocess > `DEFAULT_TEST_TIMEOUT` variable so that this can be globally tuned. > Added a test flag `--default_await_timeout` that can be used to set > the `DEFAULT_TEST_TIMEOUT` on a test run. > > > Diffs > ----- > > src/tests/agent_container_api_tests.cpp > 618569277545205017320aaf1f3a70e540d35e30 > src/tests/containerizer/cgroups_isolator_tests.cpp > 5412a7eccaa836a7f182772f1eb33b10298c96a1 > src/tests/containerizer/xfs_quota_tests.cpp > d761ea46fd4f12c6bed74090bf5ead7587f16811 > src/tests/disk_quota_tests.cpp 31cf4c44b1494afd3501046abffd303c7a1307f8 > src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 > src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae > src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c > src/tests/gc_tests.cpp 0e34c017f2c629b527915218f517b88d8392aa4b > src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 > src/tests/master_contender_detector_tests.cpp > 015d310b72a152829641d436f7cb558f72dfd77c > src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 > src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028 > src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f > > > Diff: https://reviews.apache.org/r/65202/diff/8/ > > > Testing > ------- > > make check (Fedora 27). > > > Thanks, > > James Peach > >
