----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65523/#review196920 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 7:12 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65523/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2018, 7:12 p.m.) > > > Review request for mesos, Greg Mann and Jie Yu. > > > Bugs: MESOS-8548 > https://issues.apache.org/jira/browse/MESOS-8548 > > > Repository: mesos > > > Description > ------- > > The metrics test unnecessarily set up the disk profile module without > providing the profile config file. This may cause the profile module to > pull a non-existent file. Also, it could kill the plugin before SLRP > connecting to the endpoint, making SLRP wait for 1 minute. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > ce241617ee555e5a67e552dd30b0e7afee161386 > > > Diff: https://reviews.apache.org/r/65523/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
