----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197127 -----------------------------------------------------------
src/checks/checker_process.cpp Lines 1017-1020 (patched) <https://reviews.apache.org/r/65127/#comment277251> Why did you introduce a new function? `CheckerProcess::_httpCheck` doesn't look like a continuation, since it is called directly (and synchronously) by `CheckerProcess::httpCheck`. src/checks/checker_process.cpp Lines 1188 (patched) <https://reviews.apache.org/r/65127/#comment277252> Add a period at the end of the line. s/health check/check/ - Gaston Kleiman On Feb. 8, 2018, 9:51 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65127/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 9:51 a.m.) > > > Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The network health checks called curl and then executed setns to > enter to container network namespace, which did not work on Windows. > To do the equivalent, Windows nows calls docker run with powershell's > curl equivalent (Invoke-WebRequest) and uses the > network=container:<ID> flag to enter the container's namespace. The > command health check was trivially fixed by replacing the hardcoded > `sh -c`. > > > Diffs > ----- > > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65127/diff/7/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
