> On Feb. 10, 2018, 2:22 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/uri_disk_profile.cpp > > Line 248 (original), 242 (patched) > > <https://reviews.apache.org/r/65594/diff/1/?file=1955886#file1955886line250> > > > > This should be removed to support missing profiles from upstream.
Will address this in a follow-up patch. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197218 ----------------------------------------------------------- On Feb. 10, 2018, 12:47 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65594/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2018, 12:47 a.m.) > > > Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > SLRP now checkpoints profiles associated with storage pools, and no > longer assumes that profiles won't be removed by the disk profile > adaptor. It will reject volume/block creation requests that use > missing profiles, but existing volumes/blocks will continue to work. > When a volume/block with a missing profiles is destroyed, it will be > converted to an empty resource, and SLRP will update the sizes of > storage pools for currently known profiles. > > > Diffs > ----- > > src/resource_provider/state.proto 8577b58b8cdb63b3daddf06ea5d12f80f9d42f2b > src/resource_provider/storage/provider.cpp > 33abc0e05a804969ae14da9cb9c58698ba1aaea5 > src/resource_provider/storage/uri_disk_profile.cpp > 665798fdb085ea34f93bd287fe6f9ab29a265cbf > > > Diff: https://reviews.apache.org/r/65594/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
