----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65552/#review197312 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Lines 3276 (patched) <https://reviews.apache.org/r/65552/#comment277452> s/shoud/should/ src/tests/default_executor_tests.cpp Lines 3450-3461 (patched) <https://reviews.apache.org/r/65552/#comment277454> Is it possible for the following race to occur? * Executor launches task group 1 (expected to fail/kill) * Executor performs the launch/kill. * Executor commits suicide because it is no longer running any tasks. * The agent sends the second task group to the now-dead executor. - Joseph Wu On Feb. 7, 2018, 12:05 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65552/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2018, 12:05 p.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod > Kone. > > > Bugs: MESOS-8468 > https://issues.apache.org/jira/browse/MESOS-8468 > > > Repository: mesos > > > Description > ------- > > Added a regression test for MESOS-8468. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > cc97e0d1fea7f4d0bc544d850593d8d91921b552 > > > Diff: https://reviews.apache.org/r/65552/diff/2/ > > > Testing > ------- > > `GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter='*ROOT_LaunchGroupFailure*' > --verbose --gtest_repeat=650 --gtest_break_on_failure` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
