> On Feb. 13, 2018, 5:30 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 7334-7336 (patched) > > <https://reviews.apache.org/r/65591/diff/1/?file=1955495#file1955495line7345> > > > > You compare operations here for resource providers. This isn't done in > > the code above for agent operations. Please add a comment, why this is > > necessary here but not for agent operations.
I added the equivalent check for operations on agent default resources. > On Feb. 13, 2018, 5:30 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 7448 (patched) > > <https://reviews.apache.org/r/65591/diff/1/?file=1955495#file1955495line7621> > > > > This doesn't feel right. We don't want to add an operation to the agent > > here, only to the respective resource provider -- but might want to update > > used resources of the agent. I have updated `addOperation`, `removeOperation` and `getOperation` to locally take resource providers into account. That way callers do not need to extract resource provider ids before being able work with operations (we have this information here though). > On Feb. 13, 2018, 5:30 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 7626-7627 (original), 7537-7538 (patched) > > <https://reviews.apache.org/r/65591/diff/1/?file=1955495#file1955495line7723> > > > > Probably needs to be updated to handle resource provider operations. Could you clarify your comment? `updateOperation` is a helper function which mutates the passed operation; AFAICT it is not intended to even know anything about where the operation is tracked. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197410 ----------------------------------------------------------- On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65591/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2018, 3:54 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8382 > https://issues.apache.org/jira/browse/MESOS-8382 > > > Repository: mesos > > > Description > ------- > > This patch adds explicit tracking of resource providers to the master > process. While we already had explicitly send resource provider > information in e.g., `UpdateSlaveMessage`, we only stored that > information aggregated over the full agent in the master up to now. > > > Diffs > ----- > > src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f > src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 > src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d > > > Diff: https://reviews.apache.org/r/65591/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
