----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review197773 -----------------------------------------------------------
Patch looks great! Reviews applied: [65581] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 9, 2018, 2:28 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65581/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2018, 2:28 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-8463 > https://issues.apache.org/jira/browse/MESOS-8463 > > > Repository: mesos > > > Description > ------- > > Most of the allocator tests were expecting a single invocation of > 'AddSave' on the allocator when registering a slave. Due to the nature > of our slave registration backoff, a single slave possibly sends > mutiple registration requests in short succession. Any event closely > connected to a slave registration will therefor be possibly invoked > multiple times over the lifetime of such test. > We now allow multiple invocations of 'AddSlave'. This patch also > enhances the timing control by introducing a paused clock over the > slave registration phase of these tests. > > > Diffs > ----- > > src/tests/cluster.cpp 19a41c7c1c303ad806daa4e5e3765a1e0b55933b > src/tests/master_allocator_tests.cpp > e4a63836ba8cae7b9cf2fce9d46a844858749182 > > > Diff: https://reviews.apache.org/r/65581/diff/3/ > > > Testing > ------- > > make check && ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest*" > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Till Toenshoff > >
