----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65403/#review197795 -----------------------------------------------------------
Ship it! Ship It! - Jeff Coffler On Feb. 8, 2018, 10:36 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65403/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 10:36 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-5882 > https://issues.apache.org/jira/browse/MESOS-5882 > > > Repository: mesos > > > Description > ------- > > Previously we mapped `O_CLOEXEC` to `O_NOINHERIT`, which is close to the > intended semantics, but not close enough. Instead, we want all Windows > handles by default to be non-inheritable, and not tie any Windows > inheritance semantics to the close-on-exec semantics. So, we define > `O_CLOEXEC` on Windows to be `0`, and remove the logging from the > `os::cloexec` family of functions because do not ever intend to > implement them. > > We achieve the "close" part of the semantics by making all handles > non-inheritable, as the intent is to avoid leaking handles. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/open.hpp > 6711f22d44b0e7c13da3abd51f9fb7b71779e868 > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > 5800ec92f85401a80cb813afd880be2e5a24a3af > > > Diff: https://reviews.apache.org/r/65403/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
