----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/#review197805 -----------------------------------------------------------
PASS: Mesos patch 65721 was successfully built and tested. Reviews applied: `['65719', '65720', '65721']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65721 - Mesos Reviewbot Windows On Feb. 20, 2018, 7:34 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65721/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2018, 7:34 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and > Joseph Wu. > > > Bugs: MESOS-8599 > https://issues.apache.org/jira/browse/MESOS-8599 > > > Repository: mesos > > > Description > ------- > > This is necessary to enable the Ninja build. This was not previously > fixed because we have not yet used Ninja on Windows. The same pattern > is used for other imported targets. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e > > > Diff: https://reviews.apache.org/r/65721/diff/1/ > > > Testing > ------- > > Built with Ninja on Windows in 17 minutes, versus 21 minutes using the VS > generator (both builds completely from scratch). > > Note that this isn't perfect; Ninja generates some warnings because the > imported libraries have both debug and release configurations pointing to the > same location. We can ignore this for now, as the build works, but it's ugly. > > > Thanks, > > Andrew Schwartzmeyer > >
