----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197911 -----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65615. Failed command: `python.exe .\support\apply-reviews.py -n -r 65615` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733 Relevant logs: - [apply-review-65615-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733/logs/apply-review-65615-stdout.log): ``` error: patch failed: src/tests/mesos.hpp:2170 error: src/tests/mesos.hpp: patch does not apply ``` - Mesos Reviewbot Windows On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65733/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 2:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, and Joseph Wu. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_ > DockerHealthStatusChange` test was flaky on Windows, because > the docker executor manually reaps the container exit code in > case that `docker run` fails to get the exit code. This logic > doesn't work on Windows, since the process might not be visible to > the container host machine, causing `TASK_FAILED` to get sent. By > removing the reaping logic on Windows, the test is much more reliable. > > > Diffs > ----- > > src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc > > > Diff: https://reviews.apache.org/r/65733/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
