----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198182 -----------------------------------------------------------
Ship it! Ship It! - Andrei Budnik On Feb. 22, 2018, 12:39 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65743/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 12:39 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. > > > Bugs: MESOS-8575 > https://issues.apache.org/jira/browse/MESOS-8575 > > > Repository: mesos > > > Description > ------- > > Because the Docker library did not immediately transition the > Future returned by `inspect()` to DISCARDED, it was safe for the > Docker containerizer to discard this Future before failing the > Promise associated with the Future returned by `launch()`. > > However, the introduction of an `onDiscard` callback in > `Docker::inspect()` makes this assumption invalid. This patch > addresses this by failing the Promise before discarding the > Future. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564 > > > Diff: https://reviews.apache.org/r/65743/diff/1/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Greg Mann > >
