-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65246/
-----------------------------------------------------------
(Updated Feb. 27, 2018, 3:31 p.m.)
Review request for mesos, Benjamin Mahler, Till Toenshoff, and Vinod Kone.
Changes
-------
Updated architecture and patch description to have a simpler logic similar to
the one in the other controllers.
Bugs: MESOS-8454
https://issues.apache.org/jira/browse/MESOS-8454
Repository: mesos
Description (updated)
-------
Adds a new button to download the logs in addition to the ability to
view them. Does not display the buttons if the master or agent does not
have an external log file or a log directory. Displays the correct logs,
i.e. if you are on a non-leading master you will get the logs of that
master and not the leading master.
Regarding the architectural choices, `HomeCtrl` is now similar to the
other controllers with an update function called when the state changes.
Diffs (updated)
-----
src/webui/master/static/agent.html 908d01d1d28f2a4fc595b581fa16515c5be1410a
src/webui/master/static/home.html df3eef61eb9564dbdfc3d138ecfd18e85f747f11
src/webui/master/static/js/controllers.js
59665869dbea77c00740e42f2590473181dfe2fe
Diff: https://reviews.apache.org/r/65246/diff/5/
Changes: https://reviews.apache.org/r/65246/diff/4-5/
Testing
-------
Tested using Google Chrome 64.0.3282.119.
Created an High Availability Mode Mesos cluster locally:
```
$ zkServer start
$ bash mesos-master.sh --port='5061' --zk='zk://127.0.0.1:2181/mesos'
--work_dir='/tmp/master1' --quorum=1
--webui_dir='/Users/Armand/Code/apache-mesos/src/webui'
--log_dir='/tmp/master1-log'
$ bash mesos-master.sh --port='5062' --zk='zk://127.0.0.1:2181/mesos'
--work_dir='/tmp/master2' --quorum=1
--webui_dir='/Users/Armand/Code/apache-mesos/src/webui'
--log_dir='/tmp/master2-log'
$ bash mesos-agent.sh --port='5051' --master='zk://127.0.0.1:2181/mesos'
--work_dir='/tmp/agent1' --log_dir='/tmp/agent1-log'
```
Tested the download and streaming features on the home and agents Web UI
endpoints, from both `http://localhost:5061/` and `http://localhost:5062/`.
New UI (masters):
New UI (agents):
Thanks,
Armand Grillet
