----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65825/#review198362 -----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp Lines 5391 (patched) <https://reviews.apache.org/r/65825/#comment278504> This is clearly bad. Would like to have another way to ensure ordering here, but it's difficult since the executor is in another process, with its own libprocess stack. src/tests/containerizer/docker_containerizer_tests.cpp Lines 5402-5406 (patched) <https://reviews.apache.org/r/65825/#comment278505> This could be flaky. There is no guarantee that we are re-setting the wrapper script before the call to `Docker::inspect()` is made by the status update handler. - Greg Mann On Feb. 28, 2018, 12:39 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65825/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2018, 12:39 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. > > > Bugs: MESOS-8574 > https://issues.apache.org/jira/browse/MESOS-8574 > > > Repository: mesos > > > Description > ------- > > Previously, the Mesos Docker executor waited for an initial > 'docker inspect' call to return before making any progress after > task launch. This meant that in some cases where the Docker CLI > was not responsive, the executor could get into an unkillable > state. This patch adds a new test, > `HungDockerTest.ROOT_DOCKER_InspectHungDuringExecutorTaskLaunch`, > to verify that recent changes will allow a scheduler to > successfully kill a Docker task in such situations. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 85e6f8739dd2d6f9119e30f13f681cf4b8dc45ed > > > Diff: https://reviews.apache.org/r/65825/diff/1/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh > --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectHungDuringExecutorTaskLaunch"` > > > Thanks, > > Greg Mann > >
