----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198581 -----------------------------------------------------------
Patch looks great! Reviews applied: [63991, 63992, 63994] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 2, 2018, 2:52 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63994/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 2:52 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > This patch adds a new test, > 'SchedulerTest.OfferOperationFeedbackValidation', > to verify that task and offer operation status updates are correctly > sent when the 'id' field is set incorrectly on an operation. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d > > > Diff: https://reviews.apache.org/r/63994/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >