----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/ -----------------------------------------------------------
(Updated March 6, 2018, 9:07 p.m.) Review request for mesos, Greg Mann, Jason Lai, Quinn Leng, and Vinod Kone. Changes ------- Subscribe only after first HEARTBEAT is also sent. Bugs: MESOS-8641 https://issues.apache.org/jira/browse/MESOS-8641 Repository: mesos Description ------- https://reviews.apache.org/r/61262 added heartbeat support to event stream, but the implementation could send a `HEARTBEAT` event before `SUBSCRIBED` event, which changed previous behavior. This patch fixed the issue by starting heartbeater only after `SUBSCRIBED` event is sent. Diffs (updated) ----- src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad Diff: https://reviews.apache.org/r/65930/diff/2/ Changes: https://reviews.apache.org/r/65930/diff/1-2/ Testing ------- Thanks, Zhitao Li