----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ -----------------------------------------------------------
(Updated March 9, 2018, 10:08 p.m.) Review request for mesos, Anand Mazumdar, Benjamin Mahler, Chun-Hung Hsiao, and Zhitao Li. Changes ------- Addressed review comments. Bugs: MESOS-7656 https://issues.apache.org/jira/browse/MESOS-7656 Repository: mesos Description ------- Map is a feature of proto2 syntax, but it can only be compiled with 3.0.0+ protobuf compiler, see the following discussion for details: https://groups.google.com/forum/#!topic/protobuf/p4WxcplrlA4 We have already upgraded the compiler from 2.6.1 to 3.3.0 in MESOS-7228. This patch adds map support in the json <-> protobuf conversion in stout. Diffs (updated) ----- 3rdparty/stout/include/stout/protobuf.hpp 4a1605e5130dbf7e8286dbb43d0d04ab4394e79a Diff: https://reviews.apache.org/r/59987/diff/7/ Changes: https://reviews.apache.org/r/59987/diff/6-7/ Testing ------- Thanks, Qian Zhang