> On March 15, 2018, 4:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Lines 404 (patched) > > <https://reviews.apache.org/r/66104/diff/1/?file=1978194#file1978194line404> > > > > Instead of the check failure. We probably should return a failure > > instead.
Do we even need to return a failure here? Is a warning log sufficient? - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199300 ----------------------------------------------------------- On March 15, 2018, 3:31 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66104/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 3:31 p.m.) > > > Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and Zhitao Li. > > > Bugs: MESOS-8651 > https://issues.apache.org/jira/browse/MESOS-8651 > > > Repository: mesos > > > Description > ------- > > The `volume/sandbox_path` isolator inserts a string of the sandbox path > to its `sandboxes` hashmap instance variable upon the launch of each > container. However, it never cleans it up properly and can cause > unbounded growth of the hashmap object, as isolators are global > singleton objects. > > The patch ensures the sandbox path associated with a given container ID > gets removed from the `sandboxes` hashmap upon container cleanup. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp > 20d5b32fb7ada1a17a40bf1a2438db4d85cf1063 > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > 5801977e93bcb8f463a2635f73e763098f2aa97d > > > Diff: https://reviews.apache.org/r/66104/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
