> On March 16, 2018, 12:23 a.m., Gaston Kleiman wrote: > > src/tests/scheduler_tests.cpp > > Lines 1239-1240 (patched) > > <https://reviews.apache.org/r/63994/diff/5-6/?file=1974906#file1974906line1245> > > > > Do we need this? My understanding is that frameworks will get offers as > > soon as they register, without having to manually advance the clock.
Yep I tested this - without the advance, the offer will not come. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199305 ----------------------------------------------------------- On March 16, 2018, 12:06 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63994/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 12:06 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > This patch adds three new scheduler tests, > 'OperationFeedbackValidationWithResourceProviderCapability', > 'OperationFeedbackValidationNoResourceProviderCapability', and > 'OperationFeedbackValidationSchedulerDriverFramework', to verify > that task and operation status updates, and error messages, are > correctly sent when the 'id' field is set incorrectly on an > operation. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d > > > Diff: https://reviews.apache.org/r/63994/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
