----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review199386 -----------------------------------------------------------
include/mesos/v1/quota/quota.proto Lines 46-48 (original), 67-69 (patched) <https://reviews.apache.org/r/65334/#comment279717> If I understand it correctly, for guarantee check, we check the set guarantee < (parent's guarantee - sum of its siblings' guarantee). In the case of top-level role, its parent's guarantee is the total cluster size. for limit check, we check the set limit < parent's limit. In the case of top-level role, its parent's limit is the total cluster size. The "overcommiting the cluster" description here is rather vague and as a reader, I probably won't get the subtle difference between limit check and guarantee check. How about being more explicit and provide the exact formula here like metioned above? include/mesos/v1/quota/quota.proto Lines 71-73 (original), 92-94 (patched) <https://reviews.apache.org/r/65334/#comment279716> "exceed the total cluster size" is not accurate, see comments above. - Meng Zhu On March 9, 2018, 5:46 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65334/ > ----------------------------------------------------------- > > (Updated March 9, 2018, 5:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Michael Park, and Meng Zhu. > > > Bugs: MESOS-8487 > https://issues.apache.org/jira/browse/MESOS-8487 > > > Repository: mesos > > > Description > ------- > > This introduces a `limit` in `QuotaInfo` and `QuotaRequest`. > > A new `UPDATE_QUOTA` master call is added as a replacement of > `SET_QUOTA` and `REMOVE_QUOTA`, which provides the new semantics > of unset limit meaning "no limit" and unset guarantee meaning > "no guarantee". > > The new APIs are marked as experimental for now. > > > Diffs > ----- > > include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6 > include/mesos/quota/quota.proto f2ed6f555e1e7b0290fefa3e301c9bdbf550bd11 > include/mesos/v1/master/master.proto > 6034bd5af8ad764f625f9fe80be08b48707bbadb > include/mesos/v1/quota/quota.proto 5dd772fee46f740b062827ed7c9704c26187cb12 > src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f > src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 > > > Diff: https://reviews.apache.org/r/65334/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
