----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/ -----------------------------------------------------------
(Updated March 19, 2018, 6:20 p.m.) Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu. Changes ------- Addressed comments Repository: mesos Description (updated) ------- Many mesos frameworks assume that path separators are forward slashes, like dcos-ui and marathon-ui. dcos-cli also assumes this. Previous to this patch, if a forward slash was given in the path variable to an HTTP API function call to the mesos agent on a Windows system, the Windows API would fail at recognizing the path, because the Windows API accepts only backslashes as path separators. To remedy this issue, we will now convert all forward slashes passed as a path to the HTTP API to back slashes on Windows agents by using the path::from_uri function. Diffs (updated) ----- src/files/files.cpp 5f92d2af722c3201200fa1d6a75dc0b87fdc6078 src/tests/files_tests.cpp c703cae03345112715aeab83cb0a74abe3e12469 Diff: https://reviews.apache.org/r/66002/diff/3/ Changes: https://reviews.apache.org/r/66002/diff/2-3/ Testing ------- Tested on both Windows and Linux, all tests pass, including the two newly enabled tests on Windows. Thanks, John Kordich
