----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66157/#review199544 -----------------------------------------------------------
Fix it, then Ship it! src/csi/utils.hpp Lines 23-24 (patched) <https://reviews.apache.org/r/66157/#comment279833> While the order of inclusion in this patch is consistent, other instances of this header being included are not. I think it should be included there like in this patch (alphabethical after C and C++ headers). Could you have a look at instances of #include <csi/spec.hpp> and fix them? - Benjamin Bannier On March 20, 2018, 12:29 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66157/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 12:29 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Fixed header inclusions for `csi/spec.hpp`. > > > Diffs > ----- > > src/csi/utils.hpp 2dd61bc500de1f97a3fb39c0571b5d3fdb4f7989 > src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74 > src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268 > > > Diff: https://reviews.apache.org/r/66157/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >