----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66161/#review199542 -----------------------------------------------------------
Looking at the symbols under `src/resource_provider/storage`, we also have `mesos::internal::StorageLocalResourceProvider` and its corresponding process. Do you think it would make sense to also change it to be e.g., `mesos::internal::storage::LocalResourceProvider`? src/resource_provider/storage/disk_profile_utils.cpp Line 30 (original), 30 (patched) <https://reviews.apache.org/r/66161/#comment279829> Not yours, but let's add a space here. src/resource_provider/storage/uri_disk_profile_adaptor.hpp Lines 50-61 (patched) <https://reviews.apache.org/r/66161/#comment279832> Could you pull out these changes into a separate patch? Here and below. - Benjamin Bannier On March 20, 2018, 12:47 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66161/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 12:47 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The name `profile` sounds both ambiguous and too specific, therefore > should be renamed to a potentially more useful `storage` namespace. > > > Diffs > ----- > > src/resource_provider/storage/disk_profile_utils.hpp > c267da2be86d8137ac9e242672703ed6e16175c7 > src/resource_provider/storage/disk_profile_utils.cpp > 3e8b0c54711648d8c21b78c49de268f49aa323b6 > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > 22e9d8bee0c82807c8b06ef65751496fcd880acf > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 665798fdb085ea34f93bd287fe6f9ab29a265cbf > src/tests/disk_profile_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6 > > > Diff: https://reviews.apache.org/r/66161/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
