----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/#review199546 -----------------------------------------------------------
Fix it, then Ship it! include/csi/spec.hpp Lines 23 (patched) <https://reviews.apache.org/r/66156/#comment279835> Not really related to this particular patch, but referencing this somewhat internal define in a public header is not great since it requires users of this header to know about our build setup. This is different from e.g., branching on say `__WINDOWS__` which is compiler-provided. Does it make sense for us to e.g., generate an empty `csi/csi.grpc.pb.h` when gRPC is not enabled and include it unconditionally here? Anyway, probably work for some other patch. - Benjamin Bannier On March 20, 2018, 12:29 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66156/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 12:29 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > By generating `csi.pb.h` even if gRPC is disabled, other Mesos protocol > buffers can embed the CSI protocol buffers. This is required if we want > to checkpoint disk profiles in `ResourceProviderState`. > > Moreover, we relaxed the precondition of compiling most files, as the > gRPC is only required by SLRP, CSI clients and the tests. > > > Diffs > ----- > > 3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 > include/csi/spec.hpp df01f44e6f89a03eff9aef77c29ca71495d767f2 > src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 > src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e > src/slave/flags.cpp 962b07c1d701f4ab819b14730fbc116b981433bb > src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 > > > Diff: https://reviews.apache.org/r/66156/diff/1/ > > > Testing > ------- > > `sudo make check` > > `make distcheck` with and without `--enable-grpc` > > > Thanks, > > Chun-Hung Hsiao > >
