> On March 20, 2018, 3:59 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/include/process/grpc.hpp
> > Lines 67 (patched)
> > <https://reviews.apache.org/r/66158/diff/1/?file=1982691#file1982691line67>
> >
> > nit: Let's make this constructor `explicit`. I think it would also make
> > sense to take the `shared_ptr` by value, and then move into member,
> >
> > explicit Channel(shared_ptr<Channel> _channel)
> > : channel(std::move(_channel)) {}
Does it make sense to have the following instead?
```
explicit Channel(shared_ptr<Channel>&& _channel)
: channel(std::move(_channel)) {}
```
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66158/#review199556
-----------------------------------------------------------
On March 20, 2018, 12:59 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66158/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 12:59 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and
> Joseph Wu.
>
>
> Bugs: MESOS-8697
> https://issues.apache.org/jira/browse/MESOS-8697
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `GRPCClientTest.*` tests now uses in-process channels instead of
> Unix domain sockets, except for `DiscardedBeforeServerStarted`, which is
> disabled on Windowns for now.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp
> edaf0410c62454df53d06957a4a8f1f6027b00bb
> 3rdparty/libprocess/src/tests/grpc_tests.cpp
> 8bb517fb5659b7010a0fe8b7b90ebb3a5c9f1157
>
>
> Diff: https://reviews.apache.org/r/66158/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> NOTE: This is not tested on Windows yet. The CMake rules are added later in
> the chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
