----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66177/#review199623 -----------------------------------------------------------
Patch looks great! Reviews applied: [66177] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 20, 2018, 6:35 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66177/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 6:35 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benno Evers. > > > Bugs: MESOS-8258 > https://issues.apache.org/jira/browse/MESOS-8258 > > > Repository: mesos > > > Description > ------- > > The test was flaky due to ignoring only TASK_STARTING status update, > while TASK_RUNNING status update might appear if a task was launched > before the Docker executor re-registered. To fix the issue, this patch > ensures that both status updates are received. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 080270281f77fc8732148e69f4d287074c66853e > > > Diff: https://reviews.apache.org/r/66177/diff/1/ > > > Testing > ------- > > ./src/mesos-tests > --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Andrei Budnik > >
