> On March 22, 2018, 6:19 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 426 (patched) > > <https://reviews.apache.org/r/66001/diff/10/?file=1985424#file1985424line434> > > > > Document the invariants by adding > > ``` > > CHECK_EQ(quotaPolicy, xfs::QuotaPolicy::ACCOUNTING); > > ```
We don't actually want this to be equal to ACCOUNTING since this should never run when it's equal to ACCOUNTING. Added a CHECK_NE > On March 22, 2018, 6:19 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 444 (patched) > > <https://reviews.apache.org/r/66001/diff/10/?file=1985424#file1985424line452> > > > > The `Resource` here should be the amount the container consumed, so you > > need to create it from the `QuotaInfo`. Ok so this answers my question from the disk.cpp:435 > On March 22, 2018, 6:19 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 169 (patched) > > <https://reviews.apache.org/r/66001/diff/10/?file=1985426#file1985426line173> > > > > Is this a copy/paste error? You need to update the `setProjectQuota` > > definition below (near line 283). I may need you to elaborate, I created two similar to how there was an existing external and internal implementation that's what I did for the method with the additional parameter. In the mean time I have updated the parameters. - Harold ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199778 ----------------------------------------------------------- On March 22, 2018, 2:11 p.m., Harold Dost wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66001/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 2:11 p.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-6575 > https://issues.apache.org/jira/browse/MESOS-6575 > > > Repository: mesos > > > Description > ------- > > New Flags for disk/xfs isolator: > - xfs_kill_containers - This will create a 10 MB buffer between the soft > and hard limits, and when the soft limit is exceeded it will > subsequently be killed. > > Functionality > - This by default disabled behavior allows for the `disk/xfs` isolator > to kill containers which surpass their limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 07e68a777aefba4dd35066f2eb207bba7f199d83 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 8d9f8f846866f9de377c59cb7fb311041283ba70 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > e034133629a9c1cf58b776f8da2a93421332cee0 > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > 2708524add1ff693b616d4fb241c4a0a3070520b > src/slave/flags.hpp 949a4783caf8aac9a246a98525a5287b0f8256d8 > src/slave/flags.cpp dd8dfb7a8a9f7c6030939c9eea841eb47deadfc4 > > > Diff: https://reviews.apache.org/r/66001/diff/10/ > > > Testing > ------- > > > Thanks, > > Harold Dost > >
