----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review200051 -----------------------------------------------------------
src/master/http.cpp Lines 1525-1526 (patched) <https://reviews.apache.org/r/66051/#comment280718> Not indented far enough. src/master/http.cpp Lines 1526 (patched) <https://reviews.apache.org/r/66051/#comment280653> s/have/have the/ src/master/http.cpp Lines 1544-1546 (patched) <https://reviews.apache.org/r/66051/#comment280712> Nit: you can probably remove this newline? src/master/http.cpp Lines 1556 (patched) <https://reviews.apache.org/r/66051/#comment280716> s/volume and addition/`volume` and `addition`/ src/master/http.cpp Lines 1558-1561 (patched) <https://reviews.apache.org/r/66051/#comment280717> Not indented far enough. src/master/http.cpp Lines 1595-1596 (patched) <https://reviews.apache.org/r/66051/#comment280719> Not indented far enough. src/master/http.cpp Lines 1614-1616 (patched) <https://reviews.apache.org/r/66051/#comment280714> Nit: I would probably remove this newline. src/master/http.cpp Lines 1625 (patched) <https://reviews.apache.org/r/66051/#comment280720> Suggestion: "The `volume` field contains the resources required for this operation." src/master/master.cpp Lines 10798-10837 (original), 10794-10839 (patched) <https://reviews.apache.org/r/66051/#comment280728> As discussed in chat, we need to update the agent's resources in the allocator for operator-initiated operations. src/master/validation.cpp Lines 198-201 (patched) <https://reviews.apache.org/r/66051/#comment280650> Let's provide more specific feedback for these cases. Perhaps: ``` if (!call.grow_volume().has_agent_id()) { return Error("Expecting 'agent_id' to be present; only agent default resources are supported right now"); } if (call.grow_volume().has_resource_provider_id()) { return Error("Expecting 'resource_provider_id' to be unset; only agent default resources are supported right now"); } ``` - Greg Mann On March 27, 2018, 6:37 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66051/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 6:37 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Implemented operator API to grow and shrink persistent volume. > > > Diffs > ----- > > src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45 > src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 > > > Diff: https://reviews.apache.org/r/66051/diff/7/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
