----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66147/#review200181 -----------------------------------------------------------
I have reverted this patch for now: https://github.com/apache/mesos/commit/5984cb72589415402f769190b124e172f72cfb39 See MESOS-8545 and MESOS-8729. - Alexander Rukletsov On March 19, 2018, 9:41 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66147/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 9:41 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues. > > > Bugs: MESOS-8545 > https://issues.apache.org/jira/browse/MESOS-8545 > > > Repository: mesos > > > Description > ------- > > Previously, http response for ATTACH_CONTAINER_INPUT call could be lost > due to immediate termination of IOSwitchboard process after termination > of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion > of sending all responses back to the agent, the agent received > disconnection error. To fix the issue, this patch adds finalization > of libprocess before returning from IOSwitchboard's main function. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard_main.cpp > 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b > > > Diff: https://reviews.apache.org/r/66147/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > Andrei Budnik > >
